Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable removal of Google repo in Debian package #4291

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Dec 31, 2019

Fixes brave/brave-browser#6912 and removes cleanup added to fix brave/brave-browser#2927.

Submitter Checklist:

Test Plan:

Build the new .deb and then in a clean

  1. Install the repo and the brave-keyring package:

    sudo apt install apt-transport-https curl
    curl -s https://brave-browser-apt-release.s3.brave.com/brave-core.asc | sudo apt-key --keyring /etc/apt/trusted.gpg.d/brave-browser-release.gpg add -
    echo "deb [arch=amd64] https://brave-browser-apt-release.s3.brave.com/ stable main" | sudo tee /etc/apt/sources.list.d/brave-browser.list
    sudo apt update
    sudo apt install brave-keyring
    
  2. Confirm that the /etc/apt/sources.list.d/brave-browser.list exists and is not empty.

  3. Install the brave-browser package:

    sudo dpkg -i brave-browser-*.deb
    
  4. Confirm that /etc/apt/sources.list.d/brave-browser.list still exists after installation and is not empty.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier requested a review from bridiver as a code owner December 31, 2019 22:58
@fmarier fmarier self-assigned this Dec 31, 2019
@fmarier fmarier added this to the 1.5.x - Nightly milestone Dec 31, 2019
…browser#2927)"

This reverts commit 5827f29.

This cleanup, released almost a year ago, should no longer be needed.
@fmarier fmarier force-pushed the disable-repo-removal-6912 branch from 38a70f2 to 8c58e4f Compare December 31, 2019 23:29
@fmarier fmarier requested a review from mbacchi January 2, 2020 18:13
Copy link
Contributor

@mbacchi mbacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@fmarier fmarier merged commit 0266020 into master Jan 2, 2020
@fmarier fmarier deleted the disable-repo-removal-6912 branch January 2, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Brave removes repo file Remove the chrome repository erroneously added by brave-browser on Linux
3 participants