Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters now show correctly on Vimeo. #4282

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Special characters now show correctly on Vimeo. #4282

merged 1 commit into from
Mar 4, 2020

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Dec 24, 2019

Fixes brave/brave-browser#5726

Special characters now show correctly on Vimeo. Semi-related: #1735.

Screen Shot 2019-12-23 at 10 32 06 PM

Screen Shot 2019-12-23 at 10 40 26 PM

## Submitter Checklist:

Test Plan:

  1. Open Brave with clean profile --rewards=staging=false and enable rewards.
  2. Go to vimeo.com/maqvoadora and open panel for publisher name set.
  3. View a video from this publisher, check panel and allow enough time to set to ac list.
  4. Submit one time and/or monthly tip.
  5. Go to rewards page and check that name displays correctly
  6. Verify that other Vimeo publishers continue to work correctly

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

cc @NejcZdovc @ryanml @masparrow

Comment on lines +103 to +110
std::string publisher_name;
const std::string publisher_json_name =
braveledger_media::ExtractData(data, "\"display_name\":\"", "\"");
const std::string publisher_json = "{\"brave_publisher\":\"" +
publisher_json_name + "\"}";
braveledger_bat_helper::getJSONValue(
"brave_publisher", publisher_json, &publisher_name);
return publisher_name;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publisher pages have a display_name in the JSON blob that can be pulled from. Should be easier since the code point can be parsed. Otherwise, a way to URIDecode would have to be called out to RewardsService.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some characters do not display nicely on rewards panel, ac and tips tables
2 participants