Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes refreshing page after clicking an ad causes multiple landed confirmations #4164

Merged
merged 1 commit into from
Dec 7, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Dec 6, 2019

Fixes brave/brave-browser#7249

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey self-assigned this Dec 6, 2019
@tmancey tmancey force-pushed the issues/7249 branch 5 times, most recently from 8de767c to e8eeb96 Compare December 6, 2019 12:55
@tmancey tmancey added the CI/skip Do not run CI builds (except noplatform) label Dec 6, 2019
@tmancey tmancey removed the CI/skip Do not run CI builds (except noplatform) label Dec 6, 2019
@tmancey tmancey force-pushed the issues/7249 branch 2 times, most recently from f0c6afd to 2b18dc1 Compare December 6, 2019 13:34
@tmancey tmancey added this to the 1.4.x - Nightly milestone Dec 6, 2019
@tmancey tmancey requested a review from emerick December 6, 2019 22:48
@tmancey tmancey merged commit e7ce9ae into master Dec 7, 2019
@tmancey tmancey deleted the issues/7249 branch December 7, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refreshing page after clicking an ad causes multiple landed confirmations
2 participants