Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct locale identifier when iOS user has custom calendar set #4069

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

kylehickinson
Copy link
Collaborator

Fixes brave/brave-browser#7029

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@kylehickinson kylehickinson added feature/ads CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Nov 25, 2019
@kylehickinson kylehickinson added this to the 1.3.x - Nightly milestone Nov 25, 2019
@kylehickinson kylehickinson self-assigned this Nov 25, 2019
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ads region on iOS is unsupported if users Calendar is set to a non-default option
2 participants