Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes scrollbar on site banner #4005

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Fixes scrollbar on site banner #4005

merged 1 commit into from
Nov 18, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 18, 2019

Resolves brave/brave-browser#6222

Submitter Checklist:

Test Plan:

  • enable rewards
  • go to site banner
  • make sure that there is no scrollbar

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Nov 18, 2019
@NejcZdovc NejcZdovc requested a review from ryanml November 18, 2019 07:29
@NejcZdovc NejcZdovc self-assigned this Nov 18, 2019
@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Nov 18, 2019
@NejcZdovc NejcZdovc requested a review from a team November 18, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tipping banner always shows a disabled vertical scrollbar
2 participants