-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependencies to brave://credits (uplift to 0.73.x) #3953
Conversation
We received permission to use these in Brave directly from the photographer, Will Christiansen.
None of these have any other changes than the license or copyright notice.
We pull in Tor binaries which we build using https://github.com/brave/tor_build_scripts
This includes all of the dependencies (excluding devDependencies) in brave-browser and brave-core package.json.
These files were only needed before these separate projects got merged into the brave-core repo.
Restarting
|
Restarting
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into 0.73.x
approved after deliberating with @brave/uplift-approvers. This was also uplifted into 0.71.x
as per #3955 so we'll need it in the other channels. Both CI/Jenkins
and CI/Travis
passed after several restarts.
Uplift of #3899
Approved, please ensure that before merging:
After you merge: