Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove macOS changes for "Fix user earns while native Windows and macOS notifications are suppressed" #3907

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Nov 7, 2019

Fixes brave/brave-browser#6818
Requires: #3084
Requires: #3892

Submitter Checklist:

Test Plan:

Confirm ad notifications appear on macOS

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey added this to the 0.74.x - Nightly milestone Nov 7, 2019
@tmancey tmancey self-assigned this Nov 7, 2019
@tmancey tmancey changed the title Revert macOS changes for "Fix user earns while native Windows and macOS notifications are suppressed" Remove macOS changes for "Fix user earns while native Windows and macOS notifications are suppressed" Nov 7, 2019
Copy link
Contributor

@masparrow masparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed and LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove macOS changes for "Fix user earns while native Windows and macOS notifications are suppressed"
2 participants