Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 78.0.3904.87 to Chromium 78.0.3904.97 #3893

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Nov 6, 2019

Fixes brave/brave-browser#6789
Related PR: brave/brave-browser#6790

Fixes brave/brave-browser#6703

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton
Copy link
Member

Restarted CI (there were some issues; thanks @linhkikuchi and @mihaiplesa for the help!). This next run should be accurate 👍

@mkarolin
Copy link
Collaborator Author

mkarolin commented Nov 8, 2019

CI fails on Mac for unit/browser tests with install_name_tool: changing install names or rpaths can't be redone.

@bsclifton bsclifton self-requested a review November 8, 2019 16:15
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already in 0.70.x (which works great!) - CI had a failure on macOS, which is a known problem:
brave/brave-browser#6515

Other than that, CI passed beautifully!

@bsclifton bsclifton changed the title WIP: Upgrade patches from Chromium 78.0.3904.87 to Chromium 78.0.3904.97 Upgrade patches from Chromium 78.0.3904.87 to Chromium 78.0.3904.97 Nov 8, 2019
@bsclifton bsclifton merged commit 658dde8 into master Nov 8, 2019
@bsclifton bsclifton deleted the 78.0.3904.97 branch November 8, 2019 16:29
mkarolin pushed a commit that referenced this pull request Nov 8, 2019
Upgrade patches from Chromium 78.0.3904.87 to Chromium 78.0.3904.97
mkarolin pushed a commit that referenced this pull request Nov 8, 2019
Upgrade patches from Chromium 78.0.3904.87 to Chromium 78.0.3904.97
mkarolin pushed a commit that referenced this pull request Nov 8, 2019
Upgrade patches from Chromium 78.0.3904.87 to Chromium 78.0.3904.97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
2 participants