Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding state for unsupported ads regions to ntp rewards widget #3876

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 4, 2019

Fixes brave/brave-browser#6759

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 0.73.x - Nightly milestone Nov 4, 2019
@ryanml ryanml requested a review from a team November 4, 2019 20:28
@ryanml ryanml self-assigned this Nov 4, 2019
@ryanml ryanml force-pushed the no-ads-ntp branch 5 times, most recently from 8f990c9 to 2889fbe Compare November 5, 2019 23:25
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml modified the milestones: 0.73.x - Dev, 0.74.x - Nightly Nov 7, 2019
@ryanml ryanml merged commit f47e66f into master Nov 7, 2019
@ryanml ryanml deleted the no-ads-ntp branch November 7, 2019 04:46
ryanml added a commit that referenced this pull request Nov 7, 2019
Adding state for unsupported ads regions to ntp rewards widget
ryanml added a commit that referenced this pull request Nov 7, 2019
Adding state for unsupported ads regions to ntp rewards widget
ryanml added a commit that referenced this pull request Nov 7, 2019
Adding state for unsupported ads regions to ntp rewards widget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTP Widget should indicate when Ads are not supported in the users region
2 participants