Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error with fonts #387

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Fix build error with fonts #387

merged 1 commit into from
Sep 4, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 4, 2018 •
edited by NejcZdovc
Loading

Fix brave/brave-browser#947

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy requested a review from NejcZdovc September 4, 2018 15:44
@bbondy bbondy merged commit 4f1e8df into master Sep 4, 2018
@bsclifton bsclifton deleted the fix-build-error-with-fonts branch September 26, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix build error with fonts
2 participants
@bbondy @NejcZdovc