BAT Points updates for unsupported regions (0.72)

[ryanml]

Uplift of: #3751
Fixes brave/brave-browser#6480
Fixes brave/brave-browser#6577

[kjozwiak]

Restarting as it doesn't look like it ran correctly and timed out after ~6mins.

[kjozwiak]

Looks like Win x64 failed due to the following error as per https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3751-72/1/execution/node/433/log/:

00:33:29 WindowsError: [Error 123] The filename, directory name, or volume label syntax is incorrect: 'C:\\Users\x07dministrator'

This will need to be rebased and restarted now that the above error was fixed with brave/brave-browser#6672.

macOS will also need to be restarted due to the following failures:

• https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3751-72/1/execution/node/680/log/:

04:57:39  Brave Browser Nightly Framework.dSYM/Contents/Resources/DWARF/Brave Browser Nightly Framework: the DIE at offset 0x3e1dc4ae has a DW_AT_abstract_origin attribute referring to the die at offset 0x3e1dc778, which either was not marked as an inline, or comes later in After 20s process did not stop

• https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3751-72/1/execution/node/649/log/

04:36:56  [254/259] CXX obj/brave/test/brave_browser_tests/rewards_service_browsertest.o
04:38:03  Sending interrupt signal to process
04:38:05  ninja: error: remove(brave_browser_tests.dSYM): Directory not empty
04:38:05  ninja: build stopped: interrupted by user.
04:38:05  ninja: error: remove(brave_browser_tests.dSYM): Directory not empty
04:38:05  script returned exit code 143

[kjozwiak]

Restarting macOS due to the following failures:

• https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3751-72/2/execution/node/444/log/

20:22:46  FAILED: alwaysrununittests/test_adblock_install_name 
20:22:46  python ../../build/gn_run_binary.py /usr/bin/install_name_tool -change @loader_path/../../Libraries/libadblock.dylib @executable_path/gen/adblock/out/x86_64-apple-darwin/release/libadblock.dylib brave_unit_tests
20:22:46  error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: changing install names or rpaths can't be redone for: brave_unit_tests (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)
20:22:46  /usr/bin/install_name_tool failed with exit code 1
20:22:46  [2/6] ACTION //brave/vendor/adblock_rust_ffi:test_adblock_install_name_browser_tests(//build/toolchain/mac:clang_x64)
20:22:46  ninja: build stopped: subcommand failed.
20:22:46  null
20:22:46  null
20:22:46  npm ERR! code ELIFECYCLE

• https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3751-72/2/execution/node/461/log/

20:23:00  FAILED: alwaysrununittests/test_adblock_install_name 
20:23:00  python ../../build/gn_run_binary.py /usr/bin/install_name_tool -change @loader_path/../../Libraries/libadblock.dylib @executable_path/gen/adblock/out/x86_64-apple-darwin/release/libadblock.dylib brave_unit_tests
20:23:00  error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: changing install names or rpaths can't be redone for: brave_unit_tests (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)
20:23:00  /usr/bin/install_name_tool failed with exit code 1
20:23:00  [2/6] ACTION //brave/vendor/adblock_rust_ffi:test_adblock_install_name_browser_tests(//build/toolchain/mac:clang_x64)
20:23:00  ninja: build stopped: subcommand failed.
20:23:01  null
20:23:01  null
20:23:01  npm ERR! code ELIFECYCLE
20:23:01  npm ERR! errno 1
20:23:01  npm ERR! [email protected] test: `node ./scripts/commands.js test "brave_browser_tests" "Release" "--output" "brave_browser_tests.xml"

[kjozwiak]

Going to restart macOS one more time due to rm -rf src/brave npm run init failing as per https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3751-72/3/execution/node/319/log/.

[kjozwiak]

Retrying one more time due to the following two failures on macOS:

• https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3751-72/4/execution/node/389/log/

12:59:49  ninja: Entering directory `/Users/jenkins/jenkins/workspace/_browser-build-pr_uplift-3751-72/src/out/Release'
12:59:49  [1/6] ACTION //brave/vendor/adblock_rust_ffi:test_adblock_install_name_unit_tests(//build/toolchain/mac:clang_x64)
12:59:49  FAILED: alwaysrununittests/test_adblock_install_name 
12:59:49  python ../../build/gn_run_binary.py /usr/bin/install_name_tool -change @loader_path/../../Libraries/libadblock.dylib @executable_path/gen/adblock/out/x86_64-apple-darwin/release/libadblock.dylib brave_unit_tests
12:59:49  error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: changing install names or rpaths can't be redone for: brave_unit_tests (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)
12:59:49  /usr/bin/install_name_tool failed with exit code 1
12:59:49  [2/6] ACTION //brave/vendor/adblock_rust_ffi:test_adblock_install_name_browser_tests(//build/toolchain/mac:clang_x64)
12:59:49  ninja: build stopped: subcommand failed.
12:59:49  null
12:59:49  null
12:59:49  npm ERR! code ELIFECYCLE

• https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3751-72/4/execution/node/406/log/

13:00:00  ninja: Entering directory `/Users/jenkins/jenkins/workspace/_browser-build-pr_uplift-3751-72/src/out/Release'
13:00:04  [1/6] ACTION //brave/vendor/adblock_rust_ffi:test_adblock_install_name_unit_tests(//build/toolchain/mac:clang_x64)
13:00:04  FAILED: alwaysrununittests/test_adblock_install_name 
13:00:04  python ../../build/gn_run_binary.py /usr/bin/install_name_tool -change @loader_path/../../Libraries/libadblock.dylib @executable_path/gen/adblock/out/x86_64-apple-darwin/release/libadblock.dylib brave_unit_tests
13:00:04  error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: changing install names or rpaths can't be redone for: brave_unit_tests (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)
13:00:04  /usr/bin/install_name_tool failed with exit code 1
13:00:04  [2/6] ACTION //brave/vendor/adblock_rust_ffi:test_adblock_install_name_browser_tests(//build/toolchain/mac:clang_x64)
13:00:04  ninja: build stopped: subcommand failed.
13:00:04  null
13:00:04  null
13:00:04  npm ERR! code ELIFECYCLE

@ryanml is going to attempt running the above on macOS locally to check if both unit and browser tests pass. If those end up working and this keeps failing, will approve and uplift.

[kjozwiak]

Uplift into 0.72.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis finally passed after several retries. I also QA'd #3751 (comment) and everything was working was expected 👍

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.