Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt password managers from the Uphold content script restrictions #3685

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Oct 12, 2019

This should mitigate some of the bad UX described in brave/brave-browser#6309.

Submitter Checklist:

Test Plan:

  1. Install the 1 Password X extension.
  2. Go into brave://rewards and start verifying the wallet with Uphold.
  3. On the Uphold account creation / login page, click on the 1Password icon.

If the icon is working (as opposed to being disabled and contained within a circle), then this change is working.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier requested a review from bridiver as a code owner October 12, 2019 00:20
@fmarier fmarier self-assigned this Oct 12, 2019
@fmarier fmarier force-pushed the francois-whitelist-password-managers-6309 branch from 8bae77b to d563ca1 Compare October 12, 2019 03:10
@szaimen
Copy link

szaimen commented Oct 12, 2019

@fmarier I would like to see Enpass and SafeInCloud beeing included here. (These are good password managers that aren't based on subscriptions)
Thank you for your work!
Please pink me if you need links to their websites or chrome webstore extensions.

@fmarier
Copy link
Member Author

fmarier commented Oct 14, 2019

@szaimen Are you talking about these ones?

@szaimen
Copy link

szaimen commented Oct 14, 2019

Are you talking about these ones?

  • Enpass (extension)
  • SafeInCloud (extension)

@fmarier Yes 👍

@fmarier fmarier force-pushed the francois-whitelist-password-managers-6309 branch from d563ca1 to a6f3c37 Compare October 17, 2019 00:23
@fmarier fmarier added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Oct 17, 2019
@fmarier
Copy link
Member Author

fmarier commented Oct 17, 2019

Not sure why CI is not showing up as green, but I have one run which passed except for Android:
https://staging.ci.brave.com/job/brave-browser-build-pr/job/francois-whitelist-password-managers-6309/3/

and a rebuild just on Android which also passed:
https://staging.ci.brave.com/job/brave-browser-build-pr/job/francois-whitelist-password-managers-6309/6/

@fmarier fmarier removed CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants