-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exempt password managers from the Uphold content script restrictions #3685
Conversation
8bae77b
to
d563ca1
Compare
@fmarier I would like to see Enpass and SafeInCloud beeing included here. (These are good password managers that aren't based on subscriptions) |
@szaimen Are you talking about these ones? |
@fmarier Yes 👍 |
This should mitigate some of the bad UX described in brave/brave-browser#6309.
d563ca1
to
a6f3c37
Compare
Not sure why CI is not showing up as green, but I have one run which passed except for Android: and a rebuild just on Android which also passed: |
This should mitigate some of the bad UX described in brave/brave-browser#6309.
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
brave://rewards
and start verifying the wallet with Uphold.If the icon is working (as opposed to being disabled and contained within a circle), then this change is working.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.