Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile avatars getting button style overrides instead of avatar circles #3568

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Fix profile avatars getting button style overrides instead of avatar circles #3568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions ui/webui/resources/polymer_overriding.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,28 +35,32 @@
}
}
/* Default button */
:host {
/* Ignore buttons with style attribute as they are most likely
buttons that are copmletely overriding the default button
style, e.g. avatar icons. See
https://github.com/brave/brave-browser/issues/5977. */
:host(:not([style])) {
font-family: Muli !important;
border-radius: 20px !important;
border: 1px solid;
border-color: var(--brave-default-border) !important;
color: var(--brave-text-color) !important;
outline: none;
}
:host-context(.focus-outline-visible):host(:focus) {
:host-context(.focus-outline-visible):host(:not([style]):focus) {
box-shadow: 0 0 0 3px var(--brave-focus-outline) !important;
}
/* Action button */
:host(.action-button) {
:host(:not([style]).action-button) {
background-color: var(--brave-brand-color) !important;
color: #ffffff !important;
border: none !important;
}
:host(.action-button:hover) {
:host(:not([style]).action-button:hover) {
background: var(--brave-primary-hover) !important;
}
/* Not-action button */
:host(:not(.action-button):hover) {
:host(:not(.action-button, [style]):hover) {
background: none !important;
border-color: var(--brave-brand-color) !important;
color: var(--brave-brand-color) !important;
Expand Down