-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tipping Banner accessibility/style/copy updates #3531
Conversation
components/brave_rewards/resources/ui/components/donate/index.tsx
Outdated
Show resolved
Hide resolved
1448f4f
to
9bc18d5
Compare
@NejcZdovc per discussion querySelector call was removed, validation happens at the |
@ryanml Changes LGTM, but FYI;
But, with Autoplay enabled;
|
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
components/brave_rewards/resources/ui/components/donate/index.tsx
Outdated
Show resolved
Hide resolved
9008f17
to
8ee8590
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Various style/copy updates
Fixes: brave/brave-browser#6147
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Defined in issue, be sure to have BAT on hand
Reviewer Checklist:
After-merge Checklist:
changes has landed on.