Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Mode: remove UI button (0.68.x) #3396

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

petemill
Copy link
Member

@petemill petemill commented Sep 10, 2019

The Reader Mode feature is not ready yet and whilst a flag exists, we default it to on (unlike Chromium) since we use the backend of the feature as a component for the Brave Ads feature

Address brave/brave-browser#5951 for 0.68.x

Submitter Checklist:

Test Plan:

  • Open a site
  • Reader Button should not be there
  • Change URL
  • Reader Button should still not be there

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@petemill petemill added this to the 0.68.x - Release Hotfix 2 milestone Sep 10, 2019
@petemill petemill requested a review from bsclifton September 10, 2019 06:20
@petemill petemill self-assigned this Sep 10, 2019
The feature is not ready yet and whilst a flag exists, we default it to on (unlike Chromium) since we use the backend of the feature as a component for the Brave Ads feature
@petemill petemill force-pushed the c77_0.68.x-reader-mode-button branch from 0cbbea9 to ea82c7c Compare September 10, 2019 06:23
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean! 😄

@bsclifton bsclifton merged commit 58b30f8 into c77_0.68.x Sep 10, 2019
@bsclifton bsclifton deleted the c77_0.68.x-reader-mode-button branch September 10, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants