Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync: never show service error status in browser UI (uplift to 0.69.x) #3368

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Sync: never show service error status in browser UI (uplift to 0.69.x) #3368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions chromium_src/chrome/browser/sync/sync_ui_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Copyright 2019 The Brave Authors. All rights reserved.
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
// you can obtain one at http://mozilla.org/MPL/2.0/.

#define GetMessagesForAvatarSyncError \
GetMessagesForAvatarSyncError_ChromiumImpl
#include "../../../../../chrome/browser/sync/sync_ui_util.cc"
#undef GetMessagesForAvatarSyncError

namespace sync_ui_util {

AvatarSyncErrorType GetMessagesForAvatarSyncError(
Profile* profile,
int* content_string_id,
int* button_string_id) {
// Brave Sync works differently in that there is no sign-in
// and nothing to prompt the user to manage once their sync
// chain is setup.
return NO_SYNC_ERROR;
}

} // namespace sync_ui_util