Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade WebTorrent to 0.105.1 in 0.69.x #3353

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Upgrade WebTorrent to 0.105.1 in 0.69.x #3353

merged 1 commit into from
Sep 4, 2019

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Sep 4, 2019 •
edited
Loading

Fix brave/brave-browser#5882 in 0.69.x.
0.69.x is the only milestone that's on WebTorrent 0.105.0 which has the undefined URL constructor described in brave/brave-browser#5358.
This PR is to upgrade to WebTorrent 0.105.1 in 0.69.x which has the fix for above.

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@yrliou yrliou added this to the 0.69.x - Beta milestone Sep 4, 2019
@yrliou yrliou self-assigned this Sep 4, 2019
@yrliou yrliou requested a review from a team September 4, 2019 18:06
feross
feross approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yrliou
Copy link
Member Author

yrliou commented Sep 4, 2019

CI is green and I downloaded the exe from PR builder and verified the fix using STR in brave/brave-browser#5882 on Windows 10, merging.

@yrliou yrliou merged commit ddf0473 into 0.69.x Sep 4, 2019
@yrliou yrliou deleted the upgrade_webtorrent_0.105.1_0.69.x branch September 4, 2019 21:42
@yrliou yrliou mentioned this pull request Sep 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feross feross feross approved these changes

@bbondy bbondy bbondy approved these changes

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
0.69.x-backup
Development

Successfully merging this pull request may close these issues.
3 participants
@yrliou @feross @bbondy