Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not show default chrome store url on NTP for any locale #3255

Merged
merged 1 commit into from
Aug 27, 2019
Merged

do not show default chrome store url on NTP for any locale #3255

merged 1 commit into from
Aug 27, 2019

Conversation

cezaraugusto
Copy link
Contributor

fix brave/brave-browser#5376

previous fix referenced the URL locale allowing the tile to still show for locales other than en-US.

Test Plan:

  1. Change your system locale to en-GB
  2. Clear profile
  3. NTP should not show the default chrome tile

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@cezaraugusto
do not show default chrome store url on NTP for any locale
49941e2 
fix brave/brave-browser#5376

previous fix referenced the URL locale allowing the tile to still
show for locales other than en-US.
@cezaraugusto cezaraugusto self-assigned this Aug 26, 2019
petemill
petemill approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ IMO should request to uplift since this is a branding issue cc @rebron

@petemill petemill merged commit e5f17a4 into master Aug 27, 2019
@petemill petemill deleted the ca-5376 branch August 27, 2019 21:42
@kjozwiak
Copy link
Member

Adding this into the 0.71.x milestone as this landed in master. Also moving brave/brave-browser#5376.

@kjozwiak kjozwiak added this to the 0.71.x - Nightly milestone Aug 27, 2019
cezaraugusto pushed a commit that referenced this pull request Aug 27, 2019
@petemill @cezaraugusto
do not show default chrome store url on NTP for any locale (#3255)
66f136f 
do not show default chrome store url on NTP for any locale
cezaraugusto pushed a commit that referenced this pull request Aug 27, 2019
@petemill @cezaraugusto
do not show default chrome store url on NTP for any locale (#3255)
f471138 
do not show default chrome store url on NTP for any locale
This was referenced Aug 27, 2019
Merged
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Sep 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petemill petemill petemill approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@cezaraugusto cezaraugusto

Labels
feature/newtab
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging this pull request may close these issues.

NTP for non-US/CAN locales contains chrome webstore tile
3 participants
@cezaraugusto @kjozwiak @petemill