Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add always show bookmark bar on NTP option (Uplift 2869 to dev) #3243

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Aug 23, 2019

Uplift #2869
Fixes brave/brave-browser#4782

Add always show bookmark bar on NTP option

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

…ption

Add always show bookmark bar on NTP option
@simonhong simonhong added this to the 0.70.x - Dev milestone Aug 23, 2019
@simonhong simonhong requested a review from bridiver as a code owner August 23, 2019 09:00
@simonhong simonhong self-assigned this Aug 23, 2019
@rebron rebron requested a review from a team August 23, 2019 19:48
@simonhong simonhong mentioned this pull request Aug 27, 2019
32 tasks
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.70.x approved after deliberating with @brave/uplift-approvers. Looks like both CI/Jenkins and CI/Travis have passed without errors or failures. Please make sure that all the correct labels are added and the associated issue is moved into the correct milestone.

@bsclifton bsclifton merged commit 13f85d4 into 0.70.x Aug 27, 2019
@bsclifton bsclifton deleted the uplift_2869_to_dev branch August 27, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants