Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes user feedback loop crash if ads are disabled or region is not supported #3174

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Fixes user feedback loop crash if ads are disabled or region is not supported #3174

merged 1 commit into from
Aug 14, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 14, 2019

Fixes brave/brave-browser#5659
Uplift request for #3173

@tmancey tmancey added this to the 0.70.x - Dev milestone Aug 14, 2019
@tmancey tmancey requested a review from a team August 14, 2019 13:24
@tmancey tmancey self-assigned this Aug 14, 2019
kjozwiak
kjozwiak approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.70.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@tmancey tmancey merged commit bb65963 into 0.70.x Aug 14, 2019
@tmancey tmancey deleted the issues/5659-0.70.x branch August 14, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
bug feature/ads
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak