Default shield advanced view to TRUE for existing users.

[bsclifton]

Fixes brave/brave-browser#5582

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

1. Have an existing profile (before 0.69.x)
2. Launch this version
3. Look in brave://settings and confirm advanced view is chosen
4. Open brave.com and click shields. Verify advanced view is shown
5. Close Brave
6. New profile and launch
7. Look in brave://settings and confirm simple view is chosen
8. Open brave.com and click shields. Verify simple view is shown

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[petemill]

Verified that this doesn't affect new additional user profiles that are created. In other words, IsFirstRun() returns true for those profiles too.

[petemill]

Browser test is failing, possibly because of changed expected value

[  FAILED  ] BraveProfilePrefsBrowserTest.MiscBravePrefs, where TypeParam =  and GetParam() =  (1116 ms)
[238/238] BraveProfilePrefsBrowserTest.MiscBravePrefs (1315 ms)
1 test failed:
    BraveProfilePrefsBrowserTest.MiscBravePrefs (../../brave/browser/brave_profile_prefs_browsertest.cc:25)

[bsclifton]

ah- good catch... thanks! 😄 Will address

[bsclifton]

Some lint failures - not sure on the other failures here (some builds worked fine). Will fix the lints soon and push again later tonite

[cezaraugusto]

confirmed manual test works. ++ once tests are passing

[bsclifton]

Build worked great (all tests + lint passed), except for android. Need to troubleshoot this:
https://staging.ci.brave.com/job/brave-browser-build-pr/job/bsc-shields-advanced-default-change/4/execution/node/425/log/

23:08:30 ld.lld: error: undefined symbol: first_run::IsChromeFirstRun()
23:08:30 >>> referenced by brave_profile_prefs.cc:55 (../../brave/browser/brave_profile_prefs.cc:55)
23:08:30 >>> thinlto-cache/Thin-471adf.tmp.o:(brave::RegisterProfilePrefs(user_prefs::PrefRegistrySyncable*))
23:08:30 clang: error: linker command failed with exit code 1 (use -v to see invocation)
23:08:30 ninja: build stopped: subcommand failed.

[bsclifton]

OK this should be G2G now - let's let CI finish 😄

[bsclifton]

@petemill @cezaraugusto can you please re-review? 😄

[mkarolin]

@bsclifton BraveProfilePrefsBrowserTest.AdvancedShieldsExistingUserValue is crashing for me on Windows. CI doesn't run browser tests on Windows :(.

[bsclifton]

@mkarolin oh no! Thanks for the heads up (about browser tests not working on Windows and that this fails)

Booting up my VM now to try this out...

If there's not a solution soon, I'll create a PR to revert

[bsclifton]

update: I ran tests on Win64 (in release mode) and it worked great. Might be a DCHECK failure. Will compile debug and re-run

[bsclifton]

Error looks like this:

[8784:8388:0819/155955.361:FATAL:thread_restrictions.cc(76)] Check failed: !g_blocking_disallowed.Get().Get(). Function marked as blocking was called from a scope that disallows blocking! If this task is running inside the ThreadPool, it needs to have MayBlock() in its TaskTraits. Otherwise, consider making this blocking work asynchronous or, as a last resort, you may use ScopedAllowBlocking (see its documentation for best practices).
g_blocking_disallowed currently set to true by

[bsclifton]

Created brave/brave-browser#5736 to track this problem; will fix ASAP 😄