Fixes 503 response does not add confirmation to queue - 0.68.x #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes brave/brave-browser#5548 * Fix race condition where same token was reused due to network latency etc. * Fix issue where only 1 failed confirmation was retried per session * Migrate failed confirmation tokens which return HTTP_NOT_FOUND due to race condition * Fix HTTP_BAD_REQUEST errors when retrying failed confirmations if the confirmation was already created
kjozwiak
reviewed
Aug 20, 2019
There was a problem hiding this comment.
Talked to @jsecretan on Friday and we decided that #3126 can go through the trains until it's released in 0.70.x on October 1, 2019. The situation with the backend sending back 500 and 503 errors has improved. If the need to get this into the release channel arises again, we can revisit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#5599
Uplift request for #3126