-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes no ads enable alert, ads are enabled by default when upgrading build from 0.62.51 to 0.67.119 #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
Jul 31, 2019
NejcZdovc
reviewed
Jul 31, 2019
NejcZdovc
reviewed
Jul 31, 2019
NejcZdovc
reviewed
Jul 31, 2019
NejcZdovc
reviewed
Jul 31, 2019
NejcZdovc
reviewed
Jul 31, 2019
tmancey
force-pushed
the
issues/5434
branch
2 times, most recently
from
July 31, 2019 09:52
7d3630d
to
0479c27
Compare
tmancey
force-pushed
the
issues/5434
branch
3 times, most recently
from
July 31, 2019 11:53
a527b3f
to
6716ae5
Compare
NejcZdovc
previously approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good. Testing it e2e will be done by @tmancey and QA after merge on nightly. Please wait for CI to complete.
NejcZdovc
previously approved these changes
Jul 31, 2019
emerick
previously approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tmancey
force-pushed
the
issues/5434
branch
7 times, most recently
from
August 1, 2019 17:45
03732ab
to
762b0e5
Compare
…build from 0.62.51 to 0.67.119
emerick
approved these changes
Aug 2, 2019
32 tasks
tmancey
added a commit
that referenced
this pull request
Aug 5, 2019
… when upgrading build from 0.62.51 Fixes brave/brave-browser#5531 Requires #3059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#5434
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.