Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add exception for socket.io endpoint on sliver.tv (uplift to 0.69.x) #3012

Merged
merged 1 commit into from
Jul 26, 2019
Merged

add exception for socket.io endpoint on sliver.tv (uplift to 0.69.x) #3012

merged 1 commit into from
Jul 26, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jul 25, 2019 •
edited by bsclifton
Loading

Uplift of #2975
Fixes brave/brave-browser#5380

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Jul 25, 2019
@brave-builds brave-builds added this to the 0.69.x - Dev milestone Jul 25, 2019
kjozwiak
kjozwiak approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.69.x approved after deliberating with @rebron & @bbondy 👍 Please make sure that all the correct labels are added and the appropriate issue(s) are moved into the correct milestone.

@bsclifton bsclifton merged commit a34e6e0 into 0.69.x Jul 26, 2019
@bsclifton bsclifton deleted the pr2975_add-3p-cookie-exception-for-sliver_0.69.x branch July 26, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
0.69.x-backup
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @bsclifton @brave-browser-releases