Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add background image
Add volume icons but not working.
--icon
option ofpkg-dmg
seems broken now.chromium issue - https://bugs.chromium.org/p/chromium/issues/detail?id=970374
Fix brave/brave-browser#1105
To position icon in mounted finder window,
.DS_Store
should be used. It has some attributes for window size/position, background image and icon position of app and application link.To generate
.DS_Store
for each channel, https://github.com/andreyvit/create-dmg is used.I used below command line for generating them.
create-dmg --volname "Brave Browser Nightly" --volicon installer-nightly.icns --background ./dmg-background.png --window-size 602 350 --icon Brave\ Browser\ Nightly.app 150 155 --icon Applications 430 150 --format UDBZ Brave\ Browser\ Nightly.dmg ./source_dir/
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
yarn create_dist Release --channel=nightly --skip_signing
and run dmg in src/out/Release/Reviewer Checklist:
After-merge Checklist:
changes has landed on.