Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mac installer update #2782

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Update mac installer update #2782

merged 1 commit into from
Jun 25, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 25, 2019

Add background image
Add volume icons but not working.
--icon option of pkg-dmg seems broken now.
chromium issue - https://bugs.chromium.org/p/chromium/issues/detail?id=970374

Fix brave/brave-browser#1105

Screen Shot 2019-06-25 at 16 10 53

To position icon in mounted finder window, .DS_Store should be used. It has some attributes for window size/position, background image and icon position of app and application link.

To generate .DS_Store for each channel, https://github.com/andreyvit/create-dmg is used.
I used below command line for generating them.
create-dmg --volname "Brave Browser Nightly" --volicon installer-nightly.icns --background ./dmg-background.png --window-size 602 350 --icon Brave\ Browser\ Nightly.app 150 155 --icon Applications 430 150 --format UDBZ Brave\ Browser\ Nightly.dmg ./source_dir/

Submitter Checklist:

Test Plan:

yarn create_dist Release --channel=nightly --skip_signing and run dmg in src/out/Release/

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong requested a review from bsclifton June 25, 2019 07:11
@simonhong simonhong added this to the 0.68.x - Nightly milestone Jun 25, 2019
@simonhong simonhong self-assigned this Jun 25, 2019
@simonhong simonhong requested a review from rossmoody June 25, 2019 07:11
@simonhong simonhong added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Jun 25, 2019
@simonhong simonhong marked this pull request as ready for review June 25, 2019 07:19
Add background image
Add volume icons
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this works great! The volume icon even shows up for me:
Screen Shot 2019-06-25 at 12 16 35 PM

Great job! 😄👍

@bsclifton
Copy link
Member

Thanks for capturing the steps on how you made the .DS_Store also! ❤️

@bsclifton bsclifton merged commit 13df075 into master Jun 25, 2019
@bsclifton bsclifton deleted the dmg_graphics branch June 25, 2019 19:20
brave-builds pushed a commit that referenced this pull request Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update macOS Installer Graphics
2 participants