separate alerting origin from download origin

[diracdeltas]

address brave/brave-browser#42939

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[diracdeltas]

took out the code above because i'm not sure we actually need it

• it only returns the name of an extension/app, not a proper message like "$app wants to download...", which seems like a bug
• i think the chromium version is just intended to return a human-friendly name for extensions/etc. it's nice to have but without it, probably we would just show the generic "this page" message, which is ok.

[goodov]

this is how it looks with this change

[diracdeltas]

@goodov thanks for testing it out. i think we can live with that and open a follow up unless you want to address it in this PR?

[diracdeltas]

security wise i think this view is better because an extension/app could name themselves "google.com" or something

[goodov]

would be nice to have it like Extension <...> wants to save. For consistency a similar change should be done for "wants to open" dialog and also for apps(?). A follow up sounds reasonable here.

[diracdeltas]

opened brave/brave-browser#42987

[brave-builds]

Released in v1.75.116