-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI Chat fullpage UI notices and polish #26678
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
a0cd28b
AIChat storage notice and more reliable initial state of agreements a…
petemill 2e100aa
More reliable determination if standalone or not
petemill 2e227da
Optimize loading by putting global variable fetching in non-react code
petemill 015a5f0
conversation-list empty notice and whole page loading indicator (and …
petemill 7b25136
fix ios
petemill cec9b01
Notice for enabling storage pref
petemill b0ae703
Full Page collapsed nav shouldn't show new conversation button if con…
petemill 181775c
notice polish
petemill 0a7a34f
AI Chat conversation items get their intended max-width and line up w…
petemill c46cbec
adjust strings based on review
petemill aed5f28
global state cleanup attempt based on review
petemill 6ab6965
nicer notice close button style
petemill 2af7db1
Fix storybook so its not always non-tab-associated conversation
petemill bbd9aa1
fix conversation title back button wrapping
petemill 6c84eb7
fix import order
petemill 5797007
fix unit test
petemill 730eebf
formatting
petemill d1def02
navigation width constant through animation
petemill abc00df
spacing variables
petemill cedc3c6
don't use ref for useeffect
petemill f37b875
nala space variables for notice
petemill 4b6d843
actually subscribe to state change!
petemill 2bc3ba2
remove duplicate string
petemill bff2e31
fix storage notice coming back because api state wasn't updated
petemill edf9058
fix css variable
petemill 922bd94
fix ios
petemill e868e42
iOS gets canShowPremiumPrompt
petemill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Brandon-T we don't need to call
objectWillChange.send()
right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. Not necessary.