Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkService migration for Tor #2647

Merged
merged 32 commits into from
Jul 10, 2019
Merged

NetworkService migration for Tor #2647

merged 32 commits into from
Jul 10, 2019

Commits on Jun 24, 2019

  1. NetworkService migration for Tor 

    When NetworkService is enabled, we only have access to profile-wise
proxy config. So we discard proxy config per url request path to have a
global proxy config for tor profile and insert username/password when it
is about to resolve proxy in net::ProxyResolutionService.

Note
1. new flow works no matter NetworkService enabled or not.
2. ProxyConfigServiceTor has to be NET exported to avoid //net circular
  dependency.
3. ProxyConfigMonitor chromium overrides is for setting profile-wise
  proxy config without setting proxy_config::prefs::kProxy which will be
  interfered by other components(ex. DataReductionProxyService)
    @darkdh @bridiver
    darkdh authored and bridiver committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    d7db72e View commit details
    Browse the repository at this point in the history

  2. Fix/Add test for tor

    @darkdh @bridiver
    darkdh authored and bridiver committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    ad06ddb View commit details
    Browse the repository at this point in the history

  3. Encapsulate brave/net in gni

    @darkdh @bridiver
    darkdh authored and bridiver committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    9a7bb1a View commit details
    Browse the repository at this point in the history

  4. Apply clang-format

    @darkdh @bridiver
    darkdh authored and bridiver committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    2a4ab7d View commit details
    Browse the repository at this point in the history

  5. Use ProxyServer for proxy uri parsing ProxyConfigServiceTor 

    And address misc review comments
    @darkdh @bridiver
    darkdh authored and bridiver committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    85392db View commit details
    Browse the repository at this point in the history

  6. Address review comments from @iefremov

    @darkdh @bridiver
    darkdh authored and bridiver committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    1201169 View commit details
    Browse the repository at this point in the history

  7. initial patch cleanup

    @bridiver
    bridiver committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    327ec7c View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. fix detection of tor profiles in ProxyResolutionService

    @bridiver
    bridiver committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    39a0e8f View commit details
    Browse the repository at this point in the history

  2. cleanup patch and fix potential concurrency issue with tor_circuit_ca… 

    …llback_
    @bridiver
    bridiver committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    68e12b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. use proxy config to reset tor circuit

    @bridiver
    bridiver committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    a7ee76c View commit details
    Browse the repository at this point in the history

  2. remove extra space in patch

    @bridiver
    bridiver committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    7219d05 View commit details
    Browse the repository at this point in the history

  3. fix new tor identity

    @bridiver
    bridiver committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    fba8d4c View commit details
    Browse the repository at this point in the history

  4. remove new tor identity for now because destroying a guest profile ha… 

    …s issues
    @bridiver
    bridiver committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    1d63b88 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2019

  1. cleanup the tor proxy map

    @bridiver
    bridiver committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    b6cd3d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2019

  1. cleanup from review comments

    @bridiver
    bridiver committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    ea95fe1 View commit details
    Browse the repository at this point in the history

  2. CircuitIsolationKey and IsTorProxy no longer need to be public

    @bridiver
    bridiver committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    0c61c9f View commit details
    Browse the repository at this point in the history

  3. use constexpr

    @bridiver
    bridiver committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    a6139f8 View commit details
    Browse the repository at this point in the history

  4. use TimeDelta milliseconds representation

    @bridiver
    bridiver committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    96a5406 View commit details
    Browse the repository at this point in the history

  5. fix lint issues

    @bridiver
    bridiver committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    c66331b View commit details
    Browse the repository at this point in the history

  6. TorProfileService -> IsTor

    @bridiver
    bridiver committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    892ec59 View commit details
    Browse the repository at this point in the history

  7. remove unnecessary MockTorProfileServiceFactory

    @bridiver
    bridiver committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    665d108 View commit details
    Browse the repository at this point in the history

  8. temporarily disable tor proxy unit tests

    @bridiver
    bridiver committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    c97b162 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. convert overly complicated webtorrent check for Tor to just disabling… 

    … webtorrent for tor profiles
    @bridiver
    bridiver committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    a847e29 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @bridiver
    bridiver committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    39bb972 View commit details
    Browse the repository at this point in the history

  3. move webtorrent test to tor profile test

    @bridiver
    bridiver committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    6a38a01 View commit details
    Browse the repository at this point in the history

  4. don't try to parse a uri into a HostPortPair

    @bridiver
    bridiver committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    92e0556 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. reenable tests

    @bridiver
    bridiver committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    2e0e6a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. Add test for ProxyConfigMonitor

    @darkdh
    darkdh committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    014d480 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2019

  1. Fix android build

    @darkdh
    darkdh committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    5eeba9f View commit details
    Browse the repository at this point in the history

  2. Disable build/include in chromium_src

    @darkdh
    darkdh committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    3bc4178 View commit details
    Browse the repository at this point in the history

  3. Fix enable_tor=false build

    @darkdh
    darkdh committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    9bb8d68 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. Fix enable_tor=false tests

    @darkdh
    darkdh committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    08e5837 View commit details
    Browse the repository at this point in the history