[AI Chat]: Conversation starter pack, for unassociated content #26379

fallaciousreasoning · 2024-11-05T23:04:54Z

Resolves brave/brave-browser#42106

Screencast.From.2024-11-07.09-31-06.webm

NTP:

Submitter Checklist:

I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on
All relevant documentation has been updated, for instance:

Test Plan:

Run Brave with --enable-features=AIChat,AIChatHistory
Navigate to chrome-untrusted://chat
There should be 4 suggested questions
Refreshing the page should regenerate the questions from the list in [Brave Leo]: Add (static) conversation starters brave-browser#40854

Note: The UI has not been updated

brave-builds · 2024-11-06T00:10:23Z

A Storybook has been deployed to preview UI for the latest push

petemill

Should we add a unit test to verify we're getting the appropriate suggestions for non-content-associated conversations?

components/ai_chat/core/browser/conversation_handler.cc

petemill

Looks great, with nits and formatting 😄

components/ai_chat/core/browser/conversation_handler.cc

components/ai_chat/core/browser/conversation_handler_unittest.cc

components/ai_chat/resources/page/components/suggested_question/index.tsx

components/ai_chat/resources/page/components/suggested_question/style.module.scss

petemill · 2024-11-12T07:28:17Z

Looks like an unrelated flakey unit test broke the linux test build, so I restarted it.

petemill · 2024-11-12T17:28:53Z

Failed again, maybe this needs a rebase

brave-builds · 2024-11-13T00:11:40Z

Released in v1.75.14

- [AIChat conversation data storage by petemill · Pull Request \#25876 · brave/brave-core](#25876) - [AI Chat conversations should persist browser restart · Issue \#42800 · brave/brave-browser](brave/brave-browser#42800) `QA/Yes` - [\[AIChat\]: Add URL based routing for different chats by fallaciousreasoning · Pull Request \#26050 · brave/brave-core](#26050) - [\[AI Chat\]: URLs for all conversations · Issue \#42055 · brave/brave-browser](brave/brave-browser#42055) `QA/Yes` - test plan: url and header variations specified - [AI Chat fullpage UI notices and polish by petemill · Pull Request \#26678 · brave/brave-core](#26678) - [AI Chat conversation list should prompt to enable history storage if it's disabled · Issue \#42576 · brave/brave-browser](brave/brave-browser#42576) `QA/Yes` - test plan: specified - [AI Chat notice for conversation storage · Issue \#42360 · brave/brave-browser](brave/brave-browser#42360) `QA/Yes` - test plan: specified - [AI Chat FullPage shouldn't show in SidePanel mode when restored at startup · Issue \#42413 · brave/brave-browser](brave/brave-browser#42413) `QA/Yes` - test plan: specified - [AI Chat becomes a trusted WebUI with an UntrustedWebUI frame for LLM-generated responses by petemill · Pull Request \#26855 · brave/brave-core](#26855) - [Change AI Chat url to chrome://leo-ai · Issue \#42817 · brave/brave-browser](brave/brave-browser#42817) `QA/Yes` - [AI Chat conversation entries should be isolated in an untrusted frame · Issue \#42818 · brave/brave-browser](brave/brave-browser#42818) `QA/No` - [\[AI Chat\]: Update copy button label by fallaciousreasoning · Pull Request \#26422 · brave/brave-core](#26422) - [Change copy button name to text if text in code block · Issue \#42117 · brave/brave-browser](brave/brave-browser#42117) `QA/Yes` - [\[AI Chat\]: Conversation starter pack, for unassociated content by fallaciousreasoning · Pull Request \#26379 · brave/brave-core](#26379) - [\[AI Chat\]: Add support for static conversation starters · Issue \#42106 · brave/brave-browser](brave/brave-browser#42106) `QA/Yes` - test plan: needs improvement - [Css tweaks and icon change for sidebar by aguscruiz · Pull Request \#26450 · brave/brave-core](#26450) - [\[Leo full page\] - Tweak to expand/collapse sidebar icons · Issue \#42068 · brave/brave-browser](brave/brave-browser#42068) `QA/Yes` - test plan: specified (check icons are correct) - [\[AI Chat\]: Update styling on suggestions by fallaciousreasoning · Pull Request \#26565 · brave/brave-core](#26565) - [\[AI Chat\]: Update suggestions style to match new design · Issue \#42107 · brave/brave-browser](brave/brave-browser#42107) `QA/Yes` - test plan: specified (check suggestions have new style) - [\[AI Chat\]: Don't show starter suggestions on non-empty chats by fallaciousreasoning · Pull Request \#26677 · brave/brave-core](#26677) - [AI Chat static conversation starters shouldn't show if conversation has chat history · Issue \#42412 · brave/brave-browser](brave/brave-browser#42412) `QA/Yes` - test plan: specified (verify conversation starters only show when applicable) - [fix hit area for leo conversations list by aguscruiz · Pull Request \#26793 · brave/brave-core](#26793) - [Leo full page - Conversation list - Make the whole item clickable instead of excluding the padding · Issue \#42552 · brave/brave-browser](brave/brave-browser#42552) `QA/No` - [\[Nala / @brave/leo\] update dependency by petemill · Pull Request \#26767 · brave/brave-core](#26767) - brave/brave-browser#42545 `QA/No`

fallaciousreasoning requested a review from petemill November 5, 2024 23:04

fallaciousreasoning requested a review from a team as a code owner November 5, 2024 23:04

github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 5, 2024

github-actions bot assigned fallaciousreasoning Nov 5, 2024

fallaciousreasoning requested a review from LorenzoMinto November 5, 2024 23:06

fallaciousreasoning force-pushed the ai-conversation-starters branch from 025f6a9 to fec09a6 Compare November 5, 2024 23:20

petemill reviewed Nov 7, 2024

View reviewed changes

components/ai_chat/core/browser/conversation_handler.cc Show resolved Hide resolved

components/ai_chat/core/browser/conversation_handler.cc Outdated Show resolved Hide resolved

components/ai_chat/core/browser/conversation_handler.cc Outdated Show resolved Hide resolved

fallaciousreasoning force-pushed the ai-conversation-starters branch from fec09a6 to a43c6e3 Compare November 10, 2024 23:10

fallaciousreasoning requested a review from petemill November 10, 2024 23:10

petemill approved these changes Nov 12, 2024

View reviewed changes

fallaciousreasoning force-pushed the ai-conversation-starters branch from a43c6e3 to 66e2830 Compare November 12, 2024 02:48

fallaciousreasoning enabled auto-merge (squash) November 12, 2024 02:48

fallaciousreasoning added 5 commits November 13, 2024 11:24

[AI Chat]: Add static conversation starters

4dd0baa

Add unittest

fa2ae06

Unify MaybeSeedQuestions and GenerateDefaultSuggestions

28bd82a

Change suggestions counts var name

365b1b2

Changes for PR

e23bff1

fallaciousreasoning force-pushed the ai-conversation-starters branch from 66e2830 to e23bff1 Compare November 12, 2024 22:25

fallaciousreasoning merged commit 879786a into master Nov 13, 2024
17 checks passed

fallaciousreasoning deleted the ai-conversation-starters branch November 13, 2024 00:00

github-actions bot added this to the 1.75.x - Nightly milestone Nov 13, 2024

petemill mentioned this pull request Dec 11, 2024

AI Chat Full Page Storage feature (uplift to 1.74.x) #26977

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AI Chat]: Conversation starter pack, for unassociated content #26379

[AI Chat]: Conversation starter pack, for unassociated content #26379

fallaciousreasoning commented Nov 5, 2024 •

edited

Loading

brave-builds commented Nov 6, 2024

petemill left a comment

petemill left a comment

petemill commented Nov 12, 2024

petemill commented Nov 12, 2024

brave-builds commented Nov 13, 2024

[AI Chat]: Conversation starter pack, for unassociated content #26379

[AI Chat]: Conversation starter pack, for unassociated content #26379

Conversation

fallaciousreasoning commented Nov 5, 2024 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

brave-builds commented Nov 6, 2024

petemill left a comment

Choose a reason for hiding this comment

petemill left a comment

Choose a reason for hiding this comment

petemill commented Nov 12, 2024

petemill commented Nov 12, 2024

brave-builds commented Nov 13, 2024

fallaciousreasoning commented Nov 5, 2024 •

edited

Loading