Whitelist Fedora updates mirrors #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some mirrors have out of date repomd.xml files that are older than the other repository metadata files (i.e. primary.xml.gz) so we were getting frequent 404 errors. Whitelist 2 mirrors for Fedora 25 and 26.
bridiver
reviewed
Jul 12, 2018
| - # overwrite the originals. | ||
| - "https://download.fedoraproject.org/pub/fedora/linux/updates/%s/x86_64/" % version, | ||
| - ] | ||
| + if version in '27': |
There was a problem hiding this comment.
you can remove this and revert back to the original
bridiver
reviewed
Jul 12, 2018
| + # overwrite the originals. | ||
| + "https://download.fedoraproject.org/pub/fedora/linux/updates/%s/x86_64/" % version, | ||
| + ] | ||
| + elif version in '26': |
There was a problem hiding this comment.
start the if here and overwrite as needed for other versions
bridiver
reviewed
Jul 12, 2018
| "https://download.opensuse.org/update/leap/%s/oss/" % version, | ||
| ] | ||
|
|
||
| +print("rpm sources list for reference:") |
There was a problem hiding this comment.
while this may be helpful, patches are fragile and I think it's best to avoid patching for debug output
|
@bridiver I just updated this PR with a reduced footprint patch. Let me know what you think. |
|
Closing this in favor of performing a high number of retries in order to find a working mirror. Opened tracking issue brave/brave-browser#667 |
NejcZdovc
pushed a commit
that referenced
this pull request
Sep 19, 2019
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
Use debug build as a default mode
petemill
pushed a commit
that referenced
this pull request
Jul 27, 2020
Use debug build as a default mode
petemill
pushed a commit
that referenced
this pull request
Jul 28, 2020
Use debug build as a default mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mirrors have out of date repomd.xml files that
are older than the other repository metadata files
(i.e. primary.xml.gz) so we were getting frequent
404 errors. Whitelist 2 mirrors for Fedora 25 and 26.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: