Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enbl SkipUndecryptablePasswords on Linux & macOS (uplift to 1.68.x) #25047

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Enbl SkipUndecryptablePasswords on Linux & macOS (uplift to 1.68.x) #25047

merged 1 commit into from
Aug 9, 2024

Conversation

brave-builds
Copy link
Collaborator

Uplift of #25040
Resolves brave/brave-browser#33548

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner August 8, 2024 14:30
@brave-builds brave-builds added this to the 1.68.x - Release #7 milestone Aug 8, 2024
@brave-builds brave-builds self-assigned this Aug 8, 2024
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Aug 8, 2024
LaurenWags
LaurenWags approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.68.x is approved 👍🏻 QA has verified the PR on 1.70.x/Nightly as per #25040 (comment) and #25040 (comment).

@LaurenWags LaurenWags merged commit 77353d2 into 1.68.x Aug 9, 2024
15 checks passed
@LaurenWags LaurenWags deleted the pr25040_szilard/33548-unexplained-data-loss_1.68.x branch August 9, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.68.x - Release #7
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @LaurenWags