Merge pull request #2384 from brave/fix-ui-generated-resources-dep #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add strings for NavigationBar on relevant WebUI data sources directly --- Uplift of #2384 Fixes brave/brave-browser#4343
Add missing brave_generated_resources_grit deps
bsclifton
force-pushed
the
uplift-nav-bar-strings-0.66.x
branch
from
dd5fbfc
to
2c28028
Compare
|
Pulled in fix from #2440 - will want to make sure CI looks good before considering for approval |
hashmi-waseem
pushed a commit
to hashmi-waseem/brave-core
that referenced
this pull request
May 6, 2024
Issues/2430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add strings for NavigationBar on relevant WebUI data sources directly
Uplift of #2384 and #2440
Fixes brave/brave-browser#4343
Fixes brave/brave-browser#4428