Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update alert color from app menu for light theme #24086

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Update update alert color from app menu for light theme #24086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions browser/ui/color/brave_color_mixer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,17 +448,17 @@ void AddBravifiedChromeThemeColorMixer(ui::ColorProvider* provider,
AddMaterialSidePanelColorMixer(provider, key);
}

// Upstream started to use same colors for all severity. But, we want to use
// upstream's previous non-material color to app menu highlight. These colors
// are copied from AddChromeColorMixer() because it's overwritten by
// AddMaterialChromeColorMixer().
// TODO(simonhong): Use leo color when it's ready.
ui::ColorMixer& mixer = provider->AddMixer();
mixer[kColorAppMenuHighlightSeverityLow] = AdjustHighlightColorForContrast(
ui::kColorAlertLowSeverity, kColorToolbar);
mixer[kColorAppMenuHighlightSeverityLow] = {
PickColorContrastingToToolbar(key, mixer, SkColorSetRGB(0x00, 0x46, 0x07),
SkColorSetRGB(0x58, 0xE1, 0x55))};
mixer[kColorAppMenuHighlightSeverityMedium] = {
PickColorContrastingToToolbar(key, mixer, SkColorSetRGB(0x4A, 0x39, 0x00),
SkColorSetRGB(0xF1, 0xC0, 0x0F))};
mixer[kColorAppMenuHighlightSeverityHigh] = {
kColorAvatarButtonHighlightSyncError};
mixer[kColorAppMenuHighlightSeverityMedium] = AdjustHighlightColorForContrast(
ui::kColorAlertMediumSeverityIcon, kColorToolbar);
PickColorContrastingToToolbar(key, mixer, SkColorSetRGB(0x7D, 0x00, 0x1A),
SkColorSetRGB(0xFF, 0xB3, 0xB2))};

if (key.custom_theme) {
return;
Expand Down
Loading