Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable lookalike url feature (uplift to 0.65.x) #2399

Merged
merged 1 commit into from
May 9, 2019
Merged

Disable lookalike url feature (uplift to 0.65.x) #2399

merged 1 commit into from
May 9, 2019

Conversation

brave-builds
Copy link
Collaborator

Uplift of #2382

@brave-builds brave-builds self-assigned this May 8, 2019
@brave-builds brave-builds added this to the 0.65.x - Beta milestone May 8, 2019
@simonhong
Copy link
Member

This PR also has lint check fail not by this PR's change.
(https://staging.ci.brave.com/job/brave-browser-build-pr/job/pr2382_disable_lookalike_url_feature_0.65.x/2/execution/node/162/log/).

kjozwiak
kjozwiak approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.65.x approved after deliberating with the @brave/uplift-approvers team. Please ensure that the correct labels are being used and the issue is moved into the correct milestone.

@simonhong simonhong merged commit 7f3b7f6 into 0.65.x May 9, 2019
@simonhong simonhong deleted the pr2382_disable_lookalike_url_feature_0.65.x branch May 9, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
0.65.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @simonhong @kjozwiak @brave-browser-releases