Replace donation with tip strings #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
requested review from
petemill,
tmancey,
emerick,
ryanml and
jasonrsadler
NejcZdovc
commented
May 8, 2019
| @@ -661,20 +661,6 @@ void BatPublishers::OnPublisherStateSaved(ledger::Result result) { | |||
| } | |||
| } | |||
|
|
|||
| std::vector<ledger::ContributionInfo> | |||
| BatPublishers::GetRecurringDonationList() { | |||
There was a problem hiding this comment.
This one is not needed anymore as we don't use it
NejcZdovc
commented
May 8, 2019
| @@ -446,11 +446,6 @@ void LedgerImpl::LoadNicewareList(ledger::GetNicewareListCallback callback) { | |||
| ledger_client_->LoadNicewareList(callback); | |||
| } | |||
|
|
|||
| std::vector<ledger::ContributionInfo> | |||
There was a problem hiding this comment.
This is not used anymore
NejcZdovc
commented
May 8, 2019
| @@ -87,15 +87,12 @@ class LedgerImpl : public ledger::Ledger, | |||
| void SetMediaPublisherInfo(const std::string& media_key, | |||
| const std::string& publisher_id) override; | |||
|
|
|||
| std::vector<ledger::ContributionInfo> | |||
| GetRecurringDonationPublisherInfo() override; | |||
There was a problem hiding this comment.
This is not used anymore
bridiver
reviewed
May 8, 2019
| @@ -32,8 +32,8 @@ source_set("browser_process") { | |||
| "brave_stats_updater_util.h", | |||
| "brave_tab_helpers.cc", | |||
| "brave_tab_helpers.h", | |||
| "brave_rewards/donations_dialog.cc", | |||
| "brave_rewards/donations_dialog.h", | |||
| "brave_rewards/tip_dialog.cc", | |||
There was a problem hiding this comment.
this stuff needs to be in brave_rewards_enabled guard
There was a problem hiding this comment.
also this should be under browser/ui/brave_rewards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#4345
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
tips flows are covered with browser tests (thx again @emerick 😃)
I would say to just make sure that thing builds and that you can tip a publisher
Reviewer Checklist:
After-merge Checklist:
changes has landed on.