-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace donation with tip strings #2388
Conversation
@@ -661,20 +661,6 @@ void BatPublishers::OnPublisherStateSaved(ledger::Result result) { | |||
} | |||
} | |||
|
|||
std::vector<ledger::ContributionInfo> | |||
BatPublishers::GetRecurringDonationList() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not needed anymore as we don't use it
@@ -446,11 +446,6 @@ void LedgerImpl::LoadNicewareList(ledger::GetNicewareListCallback callback) { | |||
ledger_client_->LoadNicewareList(callback); | |||
} | |||
|
|||
std::vector<ledger::ContributionInfo> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not used anymore
@@ -87,15 +87,12 @@ class LedgerImpl : public ledger::Ledger, | |||
void SetMediaPublisherInfo(const std::string& media_key, | |||
const std::string& publisher_id) override; | |||
|
|||
std::vector<ledger::ContributionInfo> | |||
GetRecurringDonationPublisherInfo() override; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not used anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM+++
@@ -32,8 +32,8 @@ source_set("browser_process") { | |||
"brave_stats_updater_util.h", | |||
"brave_tab_helpers.cc", | |||
"brave_tab_helpers.h", | |||
"brave_rewards/donations_dialog.cc", | |||
"brave_rewards/donations_dialog.h", | |||
"brave_rewards/tip_dialog.cc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this stuff needs to be in brave_rewards_enabled
guard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this should be under browser/ui/brave_rewards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix the first one
Resolves brave/brave-browser#4345
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
tips flows are covered with browser tests (thx again @emerick 😃)
I would say to just make sure that thing builds and that you can tip a publisher
Reviewer Checklist:
After-merge Checklist:
changes has landed on.