Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Make Brave Search default in Italy region. #23539

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

iccub
Copy link
Contributor

@iccub iccub commented May 9, 2024

Resolves brave/brave-browser#38192

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@iccub iccub added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels May 9, 2024
@iccub iccub requested a review from a team as a code owner May 9, 2024 17:30
@iccub iccub enabled auto-merge (squash) May 9, 2024 17:45
@iccub iccub merged commit 2a0d5f6 into master May 9, 2024
19 checks passed
@iccub iccub deleted the bugfix/38192 branch May 9, 2024 20:11
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 9, 2024
brave-builds added a commit that referenced this pull request May 10, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Jun 6, 2024

Verification PASSED on iPhone 11 running iOS 17.5.1 using the following build(s):

1.68.75 Chromium: 126.0.6478.26 (Official Build) nightly (64-bit)
--- | ---
Revision | 1f2b238e383f...
OS | iOS

IT (Italy) locale - PASSED

Clean Profile
  • ensured that Brave Search was selected as the default for both Standard/Private tab via Search Engines in Settings
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example Example
IMG_0271 IMG_0272 IMG_0273
Updated Profile (Google/Google)
  • installed 1.68.2 Chromium: 125.0.6422.41
  • ensured that Google was the default SE selected under Search Engines for both Standard & Private tab
  • updated to 1.68.75 Chromium: 126.0.6478.26 and ensured that Google is still the default SE for Standard & Private tabs
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
1.68.2 Chromium: 125.0.6422.41 1.68.75 Chromium: 126.0.6478.26
IMG_0274 IMG_0277
IMG_0275 IMG_0278
IMG_0276 IMG_0279
Updated Profile (DDG/Startpage)
  • installed 1.68.2 Chromium: 125.0.6422.41
  • changed the default SE to DDG under Search Engines for Standard tab
  • changed the default SE to Startpage under Search Engines for Private tab
  • updated to 1.68.75 Chromium: 126.0.6478.26
  • ensured that DDG wasn't replaced with Brave Search as the default SE for Standard tab
  • ensured that Startpage wasn't replaced with Brave Search as the default SE for Private tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
1.68.2 Chromium: 125.0.6422.41 1.68.75 Chromium: 126.0.6478.26
IMG_0280 IMG_0283
IMG_0281 IMG_0284
IMG_0282 IMG_0285

DE (Germany) locale - PASSED

Clean Profile
  • ensured that Brave Search was selected as the default for both Standard/Private tab via Search Engines in Settings
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example Example
IMG_0286 IMG_0287 IMG_0288
Updated Profile (Brave/Brave)
  • installed 1.68.2 Chromium: 125.0.6422.41
  • ensured that Brave Search was the default SE selected under Search Engines for both Standard & Private tab
  • updated to 1.68.75 Chromium: 126.0.6478.26 and ensured that Brave Search is still the default SE for Standard & Private
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
1.68.2 Chromium: 125.0.6422.41 1.68.75 Chromium: 126.0.6478.26
IMG_0289 IMG_0292
IMG_0290 IMG_0293
IMG_0291 IMG_0294
Updated Profile (Ecosia/Bing)
  • installed 1.68.2 Chromium: 125.0.6422.41
  • changed the default SE to Ecosia under Search Engines for Standard tab
  • changed the default SE to Bing under Search Engines for Private tab
  • updated to 1.68.75 Chromium: 126.0.6478.26
  • ensured that Ecosia wasn't replaced with Brave Search as the default SE for Standard tab
  • ensured that Bing wasn't replaced with Brave Search as the default SE for Private tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
1.68.2 Chromium: 125.0.6422.41 1.68.75 Chromium: 126.0.6478.26
IMG_0295 IMG_0298
IMG_0296 IMG_0299
IMG_0297 IMG_0300

PL (Poland) locale - PASSED

Clean Profile
  • ensured that Google was selected as the default for both Standard/Private tab via Search Engines in Settings
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example Example
IMG_0307 IMG_0308 IMG_0309
Updated Profile (Google/Google)
  • installed 1.68.2 Chromium: 125.0.6422.41
  • ensured that Google was the default SE selected under Search Engines for both Standard & Private tab
  • updated to 1.68.75 Chromium: 126.0.6478.26 and ensured that Google is still the default SE for Standard & Private tabs
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
1.68.2 Chromium: 125.0.6422.41 1.68.75 Chromium: 126.0.6478.26
IMG_0301 IMG_0304
IMG_0302 IMG_0305
IMG_0303 IMG_0306
Updated Profile (Qwant/Startpage)
  • installed 1.68.2 Chromium: 125.0.6422.41
  • changed the default SE to Qwant under Search Engines for Standard tab
  • changed the default SE to Startpage under Search Engines for Private tab
  • updated to 1.68.75 Chromium: 126.0.6478.26
  • ensured that Qwant wasn't replaced with Brave Search as the default SE for Standard tab
  • ensured that Startpage wasn't replaced with Brave Search as the default SE for Private tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
1.68.2 Chromium: 125.0.6422.41 1.68.75 Chromium: 126.0.6478.26
IMG_0310 IMG_0313
IMG_0311 IMG_0314
IMG_0312 IMG_0315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Update search engine default for IT
3 participants