Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4152: findFirstPartyHosts returns a value on the heap. Deleting it to avoid leaks #2262

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Apr 18, 2019

fix brave/brave-browser#4152

See here for more details: #403 (comment)

auditors: @NejcZdovc, @bsclifton

Submitter Checklist:

Test Plan:

  1. Navigate to sites with high tracker counts: cnn.com, forbes.com, nytimes.com
  2. Browser should not crash.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde requested review from bsclifton and NejcZdovc April 18, 2019 08:11
@jumde jumde self-assigned this Apr 18, 2019
@jumde
Copy link
Contributor Author

jumde commented Apr 18, 2019

Unit tests:
[351/351] WidevineBuildFlag.MustBeEnabledForNonLinux (0 ms)
SUCCESS: all tests passed.
Tests took 19 seconds.

Browser Tests:
[195/195] BraveWelcomeUIBrowserTest.StartupURLTest (27063 ms)
SUCCESS: all tests passed.

@NejcZdovc NejcZdovc added this to the 0.65.x - Nightly milestone Apr 18, 2019
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run through multiple pages and no more crashes

@NejcZdovc NejcZdovc merged commit d92d2b3 into master Apr 18, 2019
@NejcZdovc NejcZdovc deleted the fix_4152 branch April 18, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on navigating to youtube.com
2 participants