Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - Leo 1.64.x Uplift #22484

Merged
merged 5 commits into from
Mar 8, 2024
Merged

[iOS] - Leo 1.64.x Uplift #22484

merged 5 commits into from
Mar 8, 2024

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Mar 6, 2024 •
edited by kjozwiak
Loading

Summary

  • Implements In-App Payments
  • Implements Skus-SDK Payments
  • Implements Markdown parsing
  • Implement Syntax Highlighting
  • Implements PDF parsing
  • Implements Google Docs parsing
  • Implements Image to Text parsing
  • Implements Voice-Search assistant for AI-Chat
  • Implements Voice-Search assistant for Feedback
  • Implements URL-Bar AI-Chat suggestion
  • Implements AI-Chat Settings

Uplift of #22200
Uplift of #22483
Resolves brave/brave-browser#36585
Resolves brave/brave-browser#36596

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added this to the 1.63.x - Release #5 milestone Mar 6, 2024
@Brandon-T Brandon-T self-assigned this Mar 6, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner March 6, 2024 21:38
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build labels Mar 6, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Mar 7, 2024
@Brandon-T
- Implements AI-Chat for iOS
a1794e1 
- Implements In-App Payments
- Implements Skus-SDK Payments
- Implements Markdown parsing
- Implement Syntax Highlighting
- Implements PDF parsing
- Implements Google Docs parsing
- Implements Image to Text parsing
- Implements Voice-Search assistant for AI-Chat
- Implements Voice-Search assistant for Feedback
- Implements URL-Bar AI-Chat suggestion
- Implements AI-Chat Settings

Signed-off-by: Brandon <[email protected]>
@Brandon-T
Fix navigation button sizes.
e5816ac 
Fix popover background colour in dark-mode due to SwiftUI.Color -> UIColor bug.

Signed-off-by: Brandon <[email protected]>
@Brandon-T
Fix spacing on info popover
04e17a0 
Signed-off-by: Brandon <[email protected]>
@Brandon-T
Reduce shadows
f9ffde6 
Signed-off-by: Brandon <[email protected]>
@Brandon-T
Fix crash in AttributedString when empty
baa7539 
Signed-off-by: Brandon <[email protected]>
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.64.x approved 👍

@kjozwiak kjozwiak merged commit 1479af7 into 1.64.x Mar 8, 2024
13 of 14 checks passed
@kjozwiak kjozwiak deleted the Leo-iOS-1.64.x branch March 8, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Brandon-T Brandon-T

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.64.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@Brandon-T @brave-builds @kjozwiak