Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wallet): Migrate Report Tx Sent P3A question into core #22360

Merged
merged 12 commits into from
Mar 7, 2024
Merged

chore(wallet): Migrate Report Tx Sent P3A question into core #22360

merged 12 commits into from
Mar 7, 2024

Commits on Mar 3, 2024

  1. Move P3A transaction sent reporting into core

    @StephenHeaps
    StephenHeaps committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    0d4b0cd View commit details
    Browse the repository at this point in the history

  2. Resolve existing tests in KeyringServiceUnitTest

    @StephenHeaps
    StephenHeaps committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    223e55a View commit details
    Browse the repository at this point in the history

  3. Resolve existing tests in WalletDataFilesInstallerUnitTest

    @StephenHeaps
    StephenHeaps committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    985fbae View commit details
    Browse the repository at this point in the history

  4. Add BraveWalletP3A unit test for Report Eth Transaction Sent observ… 

    …ation, unit test network P3A switch.
    @StephenHeaps
    StephenHeaps committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    c01821c View commit details
    Browse the repository at this point in the history

  5. Add BraveWalletP3A unit test for Report Sol Transaction Sent observ… 

    …ation.
    @StephenHeaps
    StephenHeaps committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    8fd13e8 View commit details
    Browse the repository at this point in the history

  6. Add BraveWalletP3A unit test for Report Fil Transaction Sent observ… 

    …ation.
    @StephenHeaps
    StephenHeaps committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    14466fb View commit details
    Browse the repository at this point in the history

  7. fix presubmit; unused imports & whitespace.

    @StephenHeaps
    StephenHeaps committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    8392771 View commit details
    Browse the repository at this point in the history

  8. review(supermassive): remove whitespace to sort imports, fix header n… 

    …amespace
    @StephenHeaps
    StephenHeaps committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    62f1c1e View commit details
    Browse the repository at this point in the history

  9. review(supermassive): Remove ReportTransactionSent from mojom.

    @StephenHeaps
    StephenHeaps committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    79b3f5e View commit details
    Browse the repository at this point in the history

  10. review(supermassive): Use early return in OnTransactionStatusChanged.

    @StephenHeaps
    StephenHeaps committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    8b7cb6a View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. review(supermassive): Update TxService constructor helper to `MakeTxS… 

    …ervice` to avoid dangling pointer & cleanup.
    @StephenHeaps
    StephenHeaps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c5acc8e View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. review(supermassive): no trailing underscore for local variable names

    @StephenHeaps
    StephenHeaps committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    aff76bc View commit details
    Browse the repository at this point in the history