Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Add fastlane commands for building & testing separately #22316

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Feb 26, 2024

This introduces two new lanes: build_for_testing and test_without_building so that CI can perform these tasks separately in their respective stages (build-debug vs test). The former test lane will eventually be removed.

Resolves brave/brave-browser#36391

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This introduces two new lanes: `build_for_testing` and `test_without_building` so that CI can perform these tasks separately in their respective stages (build-debug vs test). The former `test` lane will eventually be removed.
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Feb 26, 2024
@kylehickinson kylehickinson self-assigned this Feb 26, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner February 26, 2024 15:51
@kylehickinson kylehickinson merged commit 8a22e0e into master Feb 27, 2024
20 checks passed
@kylehickinson kylehickinson deleted the ios-split-test-build branch February 27, 2024 16:27
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Feb 27, 2024
brave-builds added a commit that referenced this pull request Feb 27, 2024
brave-builds added a commit that referenced this pull request Feb 27, 2024
kjozwiak pushed a commit that referenced this pull request Feb 28, 2024
kjozwiak pushed a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate testing build & running unit tests in fastlane
2 participants