Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Update JitsiSDK to 8.6.3. #22296

Merged
merged 1 commit into from
Feb 27, 2024
Merged

[iOS] Update JitsiSDK to 8.6.3. #22296

merged 1 commit into from
Feb 27, 2024

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Feb 23, 2024

Resolves brave/brave-browser#36353

This SDK updated fixes few bugs within the Brave Talk native

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Sanity test the Brave Talk on iOS.

Resovles brave/brave-browser#36353
This SDK updated fixes few bugs within the Brave Talk native
@iccub iccub added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Feb 23, 2024
@iccub iccub requested a review from a team as a code owner February 23, 2024 21:09
@iccub
Copy link
Contributor Author

iccub commented Feb 26, 2024

note: please merge once QA finishes the verifications

@kjozwiak
Copy link
Member

@soner-yuksel
Copy link
Contributor

Verifications PASSED on various iOS devices as per brave/qa-resources#559 (comment), brave/qa-resources#559 (comment), brave/qa-resources#559 (comment) & brave/qa-resources#559 (comment).

Merging since the validation is passed and will uplift to 1.63 - 1.64

@soner-yuksel soner-yuksel merged commit 13b66a7 into master Feb 27, 2024
20 checks passed
@soner-yuksel soner-yuksel deleted the bugfix/36353 branch February 27, 2024 16:12
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Feb 27, 2024
@hffvld
Copy link
Collaborator

hffvld commented Mar 1, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.4 (21E217)
Brave build: 1.65 (45)
BraveCore: 1.65.45 (122.0.6261.94)

ACTUAL RESULTS:

  • Ensured talk.brave.com is working
  • Ensured using different orientations in calls does not cause problems
  • Ensured Car Mode and Low Bandwidth Mode are working
  • Ensured talk.brave.software is working
  • Ensured PIP is working

1 2 3 4 5
1 2 3 4 5
1 2 3 4 5

Verification passed on iPhone 13 with iOS 17.4

  • Verified able to create and join Web3 Talk with ETH NFT gating
  • Verified able to create and join Web3 Talk with ETH POAP gating
  • Verified able to create and join Web3 Talk with BAT gating
  • Verified able to create and join Web3 Talk with SOL NFT gating
  • Verified unable to join Web3 Talk when participant doesn't have the required NFT/POAP/BAT

kjozwiak pushed a commit that referenced this pull request Mar 1, 2024
Merge pull request #22296 from brave/bugfix/36353
kjozwiak pushed a commit that referenced this pull request Mar 1, 2024
Merge pull request #22296 from brave/bugfix/36353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JitsiSDK to 8.6.3
5 participants