-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added diagnostic tracing of leave sync case #21767
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted to draft after consultation with @soner-yuksel and @Brandon-T . on iOS users cannot see brave://prefs-internals, but they can see sync-internals, which seems fits more to store this information |
Brandon-T
approved these changes
Jan 30, 2024
soner-yuksel
approved these changes
Jan 30, 2024
AlexeyBarabash
force-pushed
the
diag_sync_leave_reason
branch
from
January 30, 2024 16:34
2a9e48f
to
3d72ff6
Compare
darkdh
reviewed
Jan 31, 2024
darkdh
reviewed
Jan 31, 2024
darkdh
approved these changes
Jan 31, 2024
7 tasks
AlexeyBarabash
added a commit
that referenced
this pull request
Jan 31, 2024
7 tasks
AlexeyBarabash
added a commit
that referenced
this pull request
Feb 1, 2024
kjozwiak
pushed a commit
that referenced
this pull request
Feb 2, 2024
Uplift of #21767 (squashed) to beta
kjozwiak
pushed a commit
that referenced
this pull request
Feb 2, 2024
Uplift of #21767 (squashed) to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#35609
This PR adds diagnostic info for the leave sync chain case. Info is saved into profile preferences. It must help to understand why some iOS devices randomly by themselves leave the sync chain.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Leave chain details
section, ensure it is emptyLeave chain details
, ensure it contains info about time and functions used to leave the sync chain.