Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added diagnostic tracing of leave sync case #21767

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Jan 26, 2024

Resolves brave/brave-browser#35609

This PR adds diagnostic info for the leave sync chain case. Info is saved into profile preferences. It must help to understand why some iOS devices randomly by themselves leave the sync chain.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open brave://sync-internals/, find Leave chain details section, ensure it is empty
  2. Create sync chain
  3. Leave sync chain
  4. at brave://sync-internals/, find Leave chain details, ensure it contains info about time and functions used to leave the sync chain.

image

@AlexeyBarabash AlexeyBarabash marked this pull request as ready for review January 26, 2024 14:43
@AlexeyBarabash AlexeyBarabash requested review from a team as code owners January 26, 2024 14:43
@AlexeyBarabash AlexeyBarabash marked this pull request as draft January 26, 2024 15:17
@AlexeyBarabash
Copy link
Contributor Author

Converted to draft after consultation with @soner-yuksel and @Brandon-T . on iOS users cannot see brave://prefs-internals, but they can see sync-internals, which seems fits more to store this information

@AlexeyBarabash AlexeyBarabash marked this pull request as ready for review January 29, 2024 22:29
@AlexeyBarabash AlexeyBarabash merged commit 63d746b into master Jan 31, 2024
19 checks passed
@AlexeyBarabash AlexeyBarabash deleted the diag_sync_leave_reason branch January 31, 2024 20:16
@github-actions github-actions bot added this to the 1.64.x - Nightly milestone Jan 31, 2024
AlexeyBarabash added a commit that referenced this pull request Jan 31, 2024
AlexeyBarabash added a commit that referenced this pull request Feb 1, 2024
kjozwiak pushed a commit that referenced this pull request Feb 2, 2024
kjozwiak pushed a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostics for iOS device randomly leaves the Sync chain
4 participants