"Ad notifications received" should show Ads viewed between the 1st of the month and the 4th of the following month #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerick
previously approved these changes
Apr 1, 2019
|
|
||
| exploded.hour = 0; | ||
| exploded.minute = 0; | ||
| exploded.second = 0; |
There was a problem hiding this comment.
exploded.millisecond will probably have garbage in it if you don't explicitly zero it out, though not sure if it strictly matters here.
There was a problem hiding this comment.
good catch will fix just incase a user redeems a token before 1 second passes as this redemption would not be shown in this edge case 👍
… the month and the 4th of the following month
This was referenced Apr 2, 2019
|
@tmancey can we get some tests for this? Looks like that was missed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes brave/brave-browser#3958
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
If the day of the month is less than 5 then "Ad notifications received" stats should include ads viewed between 1st of the previous month (at midnight) and the 4th of the current month (23:59:59). If the day of the month is 5 or higher then "Ad notifications received" stats should include ads viewed from the 1st of the month up until now.
Reviewer Checklist: