Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call unique() in content scripts when right clicking (uplift to 0.63.x) #2056

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Don't call unique() in content scripts when right clicking (uplift to 0.63.x) #2056

merged 2 commits into from
Apr 3, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 25, 2019 •
edited by bsclifton
Loading

Uplift of #2043 and #2063
Fixes brave/brave-browser#2410

@brave-builds brave-builds self-assigned this Mar 25, 2019
@brave-builds brave-builds added this to the 0.63.x - Dev milestone Mar 25, 2019
@bsclifton
Copy link
Member

To reviewers: let's wait until we can get a new Nightly built before merging this

@bsclifton bsclifton removed their request for review March 25, 2019 17:35
@bsclifton bsclifton force-pushed the pr2043_cosmetic-filter-call-unique-on-demand_0.63.x branch 2 times, most recently from f6d5770 to 4d515a4 Compare March 28, 2019 20:39
@bsclifton
Copy link
Member

UPDATE: works nicely on Nightly. Waiting for DEV to be sorted out, then this is ready for approval/merge

@bsclifton bsclifton force-pushed the pr2043_cosmetic-filter-call-unique-on-demand_0.63.x branch from 4d515a4 to bf3e4f7 Compare April 2, 2019 20:01
@bsclifton
Copy link
Member

Rebased - letting CI run for this. Will wait for results

kjozwiak
kjozwiak approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.63.x approved after earlier discussion in the b-c triage meeting. @bsclifton rebase looks a lot better and travis is passing. Can you just double check to make sure that the jenkins failure isn't related to this particular PR?

Please make sure that all the correct labels are used/updated and ensure that the associated issue is moved into the correct milestone.

@bsclifton
Copy link
Member

All CI passed, except for npm run audit on Linux:

14:04:13  npm ERR! audit Your configured registry (https://registry.npmjs.org/) does not support audit requests, or the audit endpoint is temporarily unavailable.

I know this happens intermittently and I don't believe we know of a fix. Good to merge 👍

@bsclifton bsclifton merged commit fb2ffe7 into 0.63.x Apr 3, 2019
@bsclifton bsclifton deleted the pr2043_cosmetic-filter-call-unique-on-demand_0.63.x branch April 3, 2019 06:03
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@kjozwiak
Release notes for 0.56.x
a053be1 
Fix #2056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
0.63.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @bsclifton @kjozwiak @brave-browser-releases