Grant access to chrome.sockets APIs for IPFS companion #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ID of the Stable channel was whitelisted in 10f16e6 but we want to allow the ID of Beta channel to have access to those APIs as well. The purpose of opt-in Beta channel is to dogfood and iterate faster without impacting regular user base.
yrliou
previously approved these changes
Mar 25, 2019
diracdeltas
reviewed
Mar 25, 2019
| @@ -2,7 +2,8 @@ | |||
| // License, v. 2.0. If a copy of the MPL was not distributed with this | |||
| // file, You can obtain one at http://mozilla.org/MPL/2.0/. | |||
| // Command to get whitelist ID: echo -n mnojpmjdmbbfmejpflffifhffcmidifd | openssl sha1 | tr '[:lower:]' '[:upper:]' | |||
| // Same for sync api: echo -n nomlkjnggnifocmealianaaiobmebgil | openssl sha1 | |||
| // Same for sync api: echo -n nomlkjnggnifocmealianaaiobmebgil | openssl sha1 | tr '[:lower:]' '[:upper:]' | |||
| // Same for ipfs-companion: echo -n nibjojkomfdiaoajekhjakgkdhaomnch | openssl sha1 | tr '[:lower:]' '[:upper:]' | |||
There was a problem hiding this comment.
780bf954c0f7c586ea9662d4f967771f49cc2114 is the sha1 of nibjojkomfdiaoajekhjakgkdhaomnch; what does FF32507DC3DB5DFFD1D6733187C84D4B74713D63 correspond to?
There was a problem hiding this comment.
IPFS beta extension, it's the 2nd commit in the PR.
diracdeltas
reviewed
Mar 25, 2019
| @@ -61,17 +62,17 @@ | |||
| "sockets.tcp": { | |||
| "dependencies": ["manifest:sockets"], | |||
| "contexts": ["blessed_extension"], | |||
| "whitelist": ["3D9518A72EB02667A773B69DBA9E72E0F4A37423"] | |||
There was a problem hiding this comment.
i assume 3D9518A72EB02667A773B69DBA9E72E0F4A37423 is webtorrent?
|
@diracdeltas I cleaned up the headers to specify the mapping and ID for each extension. |
brave-builds
pushed a commit
that referenced
this pull request
Mar 25, 2019
brave-builds
pushed a commit
that referenced
this pull request
Mar 25, 2019
This was referenced Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#3876
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: