-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant access to chrome.sockets APIs for IPFS companion #2050
Conversation
The ID of the Stable channel was whitelisted in 10f16e6 but we want to allow the ID of Beta channel to have access to those APIs as well. The purpose of opt-in Beta channel is to dogfood and iterate faster without impacting regular user base.
@@ -2,7 +2,8 @@ | |||
// License, v. 2.0. If a copy of the MPL was not distributed with this | |||
// file, You can obtain one at http://mozilla.org/MPL/2.0/. | |||
// Command to get whitelist ID: echo -n mnojpmjdmbbfmejpflffifhffcmidifd | openssl sha1 | tr '[:lower:]' '[:upper:]' | |||
// Same for sync api: echo -n nomlkjnggnifocmealianaaiobmebgil | openssl sha1 | |||
// Same for sync api: echo -n nomlkjnggnifocmealianaaiobmebgil | openssl sha1 | tr '[:lower:]' '[:upper:]' | |||
// Same for ipfs-companion: echo -n nibjojkomfdiaoajekhjakgkdhaomnch | openssl sha1 | tr '[:lower:]' '[:upper:]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
780bf954c0f7c586ea9662d4f967771f49cc2114
is the sha1 of nibjojkomfdiaoajekhjakgkdhaomnch
; what does FF32507DC3DB5DFFD1D6733187C84D4B74713D63
correspond to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPFS beta extension, it's the 2nd commit in the PR.
@@ -61,17 +62,17 @@ | |||
"sockets.tcp": { | |||
"dependencies": ["manifest:sockets"], | |||
"contexts": ["blessed_extension"], | |||
"whitelist": ["3D9518A72EB02667A773B69DBA9E72E0F4A37423"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i assume 3D9518A72EB02667A773B69DBA9E72E0F4A37423 is webtorrent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
@diracdeltas I cleaned up the headers to specify the mapping and ID for each extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fix brave/brave-browser#3876
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: