Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block default chrome url in topsites list #2037

Merged
merged 2 commits into from
Mar 26, 2019
Merged

block default chrome url in topsites list #2037

merged 2 commits into from
Mar 26, 2019

Conversation

cezaraugusto
Copy link
Contributor

fix brave/brave-browser#3805

test plan:
covered by automated tests

@cezaraugusto cezaraugusto added this to the 0.62.x - Beta milestone Mar 22, 2019
@cezaraugusto cezaraugusto self-assigned this Mar 22, 2019
@cezaraugusto cezaraugusto requested a review from bsclifton March 22, 2019 17:48
@cezaraugusto cezaraugusto changed the title Ca 3805 block default chrome url in topsites list Mar 22, 2019
This was referenced Mar 22, 2019
Merged
Merged
@bsclifton
Copy link
Member

Checking this out now...

bsclifton
bsclifton approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 😄 Tested manually and verified tests all pass locally

@cezaraugusto cezaraugusto merged commit 1a19062 into master Mar 26, 2019
@cezaraugusto cezaraugusto deleted the ca-3805 branch March 26, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
None yet
Projects
None yet
Milestone
0.64.x - Release
Development

Successfully merging this pull request may close these issues.

Can not add a page to top sites
2 participants
@cezaraugusto @bsclifton