Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BraveThemeApiBrowserTest failure on Release build (uplift to 0.63.x) #1971

Closed
wants to merge 1 commit into from
Closed

Fix BraveThemeApiBrowserTest failure on Release build (uplift to 0.63.x) #1971

wants to merge 1 commit into from

Conversation

petemill
Copy link
Member

@petemill petemill commented Mar 15, 2019 •
edited
Loading

Uplift of #1965
@brave/uplift-approvers asking for uplift because Release mode test failure introduced with #1805 which is on 0.63 via #1936

@petemill petemill self-assigned this Mar 15, 2019
@petemill petemill added this to the 0.63.x - Dev milestone Mar 15, 2019
@petemill petemill requested review from simonhong and a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv March 15, 2019 17:15
@petemill
Copy link
Member Author

Closing in favor of new uplift request

@petemill petemill closed this Mar 15, 2019
@petemill petemill deleted the 0.63.x_pr1965_fix_brave_theme_api_test_in_release_build branch March 15, 2019 17:20
@kjozwiak kjozwiak removed request for a team and simonhong March 20, 2019 02:30
@kjozwiak kjozwiak removed this from the 0.63.x - Dev milestone Mar 20, 2019
@kjozwiak kjozwiak added invalid and removed invalid labels Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petemill petemill

Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petemill @kjozwiak