Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not count urls in NTP top sites not coming from http or https #1932

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

cezaraugusto
Copy link
Contributor

fix brave/brave-browser#3710

Test plan:

  • Reset your profile
  • Open Brave
  • Open NTP
  • Should show no top sites

@cezaraugusto cezaraugusto self-assigned this Mar 13, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good; test plan works great 😄 👍

@bsclifton bsclifton added this to the 0.64.x - Nightly milestone Mar 13, 2019
@bsclifton bsclifton merged commit c1481ab into master Mar 13, 2019
@bsclifton bsclifton deleted the ntp-topsites-valid-sites branch March 13, 2019 21:13
cezaraugusto pushed a commit that referenced this pull request Mar 13, 2019
do not count urls in NTP top sites not coming from http or https
cezaraugusto pushed a commit that referenced this pull request Mar 13, 2019
do not count urls in NTP top sites not coming from http or https
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do not add internal pages in NTP top sites
2 participants