Youtube videos with custom paths now show correctly #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youtube videos with custom paths now show correctly
kjozwiak
approved these changes
Mar 7, 2019
There was a problem hiding this comment.
Uplift to 0.61.x approved after deliberating with @rebron @srirambv and @bsclifton. QA has also checked this against 0.62.x via brave/brave-browser#1886 (comment). We'll also spot check against 0.61.x. Please ensure that all associated issues are moved to the correct milestone.
@NejcZdovc seems like the CI checks are failing again. I'm not sure if this is associated with this PR but can you double check to make sure this won't cause any issues when merging?
|
@kjozwiak yup same node problem, not related to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #1703
Fixes brave/brave-browser#1886