Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception-exception list #18829

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Add exception-exception list #18829

merged 1 commit into from
Jun 16, 2023

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Jun 8, 2023

Resolves brave/brave-browser#20426

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Visit brave://components and verify that there is a Brave Ad Block First Party List entry. It should not indicate any update errors.

@antonok-edm antonok-edm self-assigned this Jun 8, 2023
@antonok-edm antonok-edm marked this pull request as ready for review June 13, 2023 05:49
Copy link
Collaborator

@ShivanKaul ShivanKaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as part of the changes I'm working on I'll move the FilterProviderManager AddProvider call to Component Filter Provider constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support overrides to the eTLD+1 exception policy from default adblock filter lists
2 participants